Wordpress 1.5.1.3 Security Fixes
Are you curious as to what changed from release 1.5.1.2 to 1.5.1.3 of Wordpress (WP)? I was, so I did a recursive diff of all the files. Here are the interesting additions:
diff -r wordpress\wp-admin\post.php wordpress-old\wp-admin\post.php
> $comment = $_GET['comment'];
> $p = $_GET['p'];
644,645c644,645
< $comment_ID = (int) $_POST['comment_ID'];
< $comment_post_ID = (int) $_POST['comment_post_ID'];
Post identifiers are now protected with an explicit cast from XSS attacks
diff -r wordpress\wp-includes\functions-post.php wordpress-old\wp-includes\functions-post.php
113a118,122
>
> // Do some escapes for safety
> $post_title = $wpdb->escape($post_title);
> $post_excerpt = $wpdb->escape($post_excerpt);
> $post_content = $wpdb->escape($post_content);
Important variables are now escaped first.
diff -r wordpress\wp-includes\version.php wordpress-old\wp-includes\version.php
5c5
< $wp_version = ‘1.5.1.3′;
—
> $wp_version = ‘1.5.1.2′;
The version has been updated, of course.
diff -r wordpress\xmlrpc.php wordpress-old\xmlrpc.php
132,141c131
< foreach ($array as $k => $v) {
< if (is_array($v)) {
< $this->escape($array[$k]);
< } else if (is_object($v)) {
< //skip
< } else {
< $array[$k] = $wpdb->escape($v);
< }
< }
< }
$args are now escaped with php, not some “special” function.
565,567c530,532
< } else if ( !empty($catnames) ) {
< $post_category = array(get_cat_ID($catnames));
< }
—
> } else {
> $post_category[] = 1;
> }
If an XML ping comes in with no category, we use a default of 1 instead.
1270a1218,1222
> $pingstatus = $wpdb->get_var("SELECT ping_status FROM $wpdb->posts WHERE ID = $post_ID");
>
> if (’open’ != $pingstatus)
> die(’Sorry, pingbacks are closed for this item.’);
>
A lot of XML ping checking and validation to make sure the ping is “good.”
That about sums it up!
This entry was posted on Wednesday, June 29th, 2005 at 11:05 pm and is tagged with wp version, catnames, xmlrpc, security fixes, cat id, args, foreach, escapes, lt, excerpt, recursive diff, release 1, array, validation, variables, additions. You can follow any responses to this entry through the RSS 2.0 feed. You can leave a response, or trackback.
Add New Comment
Viewing 3 Comments
Thanks. Your comment is awaiting approval by a moderator.
Do you already have an account? Log in and claim this comment.
Do you already have an account? Log in and claim this comment.
Do you already have an account? Log in and claim this comment.
Do you already have an account? Log in and claim this comment.
Add New Comment
Trackbacks
(Trackback URL)